On Wed, 30 Dec 2020, Arnd Bergmann wrote:
> From: Arnd Bergmann <a...@arndb.de>
>
> clang warns because the added __maybe_unused attribute is in
> the wrong place:
>
> drivers/i3c/master/mipi-i3c-hci/core.c:780:21: error: attribute declaration
> must precede definition [-Werror,-Wignored-attributes]
> static const struct __maybe_unused of_device_id i3c_hci_of_match[] = {
> ^
> include/linux/compiler_attributes.h:267:56: note: expanded
>
> Fixes: 95393f3e07ab ("i3c/master/mipi-i3c-hci: quiet maybe-unused variable
> warning")
> Signed-off-by: Arnd Bergmann <a...@arndb.de>
Acked-by: Nicolas Pitre <npi...@baylibre.com>
This might be the 3rd patch from 3 different people fixing the same
thing. Looks like I3C maintainer is on vacation. Please feel free to
send this trivial fix upstream some other way.
> ---
> drivers/i3c/master/mipi-i3c-hci/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i3c/master/mipi-i3c-hci/core.c
> b/drivers/i3c/master/mipi-i3c-hci/core.c
> index 500abd27fb22..1b73647cc3b1 100644
> --- a/drivers/i3c/master/mipi-i3c-hci/core.c
> +++ b/drivers/i3c/master/mipi-i3c-hci/core.c
> @@ -777,7 +777,7 @@ static int i3c_hci_remove(struct platform_device *pdev)
> return 0;
> }
>
> -static const struct __maybe_unused of_device_id i3c_hci_of_match[] = {
> +static const __maybe_unused struct of_device_id i3c_hci_of_match[] = {
> { .compatible = "mipi-i3c-hci", },
> {},
> };
> --
> 2.29.2
>
>
