On Wed, Dec 30, 2020 at 10:40:53PM +0100, Alexandre Belloni wrote:
> On 30/12/2020 16:23:56-0500, Nicolas Pitre wrote:
> > On Wed, 30 Dec 2020, Arnd Bergmann wrote:
> >
> > > From: Arnd Bergmann <a...@arndb.de>
> > >
> > > clang warns because the added __maybe_unused attribute is in
> > > the wrong place:
> > >
> > > drivers/i3c/master/mipi-i3c-hci/core.c:780:21: error: attribute
> > > declaration must precede definition [-Werror,-Wignored-attributes]
> > > static const struct __maybe_unused of_device_id i3c_hci_of_match[] = {
> > > ^
> > > include/linux/compiler_attributes.h:267:56: note: expanded
> > >
> > > Fixes: 95393f3e07ab ("i3c/master/mipi-i3c-hci: quiet maybe-unused
> > > variable warning")
> > > Signed-off-by: Arnd Bergmann <a...@arndb.de>
> >
> > Acked-by: Nicolas Pitre <npi...@baylibre.com>
> >
> > This might be the 3rd patch from 3 different people fixing the same
> > thing. Looks like I3C maintainer is on vacation. Please feel free to
> > send this trivial fix upstream some other way.
> >
>
> Isn't it already upstream?
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=95393f3e07ab53855b91881692a4a5b52dcdc03c
This patch is fixing that one, the attribute was added between the
struct type, causing a new warning for clang.
I sent a fix for this earlier too, I do not care which one goes in as
long as one does so:
Reviewed-by: Nathan Chancellor <natechancel...@gmail.com>
Cheers,
Nathan
