Met vriendelijke groet / kind regards,

Mike Looijmans
System Expert


TOPIC Embedded Products B.V.
Materiaalweg 4, 5681 RJ Best
The Netherlands

T: +31 (0) 499 33 69 69
E: mike.looijm...@topicproducts.com
W: www.topicproducts.com

Please consider the environment before printing this e-mail
On 06-01-2021 16:16, Sebastian Reichel wrote:
Hi,

On Wed, Jan 06, 2021 at 08:55:57AM +0100, Mike Looijmans wrote:
Add support for the LTC4162-L Li-Ion battery charger. The driver allows
reading back telemetry and to set some charging options like the input
current limit.

Signed-off-by: Mike Looijmans <mike.looijm...@topic.nl>
---
v2: Use microohm units instead of milliohm
     Add interrupt support using smbalert
     Support obtaining cell-count from devicetree
v3: Fix overflows in calculations involving resistor values
v4: Use attr_grp member to register attributes
     Report input current/voltage for charger and make battery
     voltage and current into sysfs attributes
Fine with me until we have a better way to solve the problem. IIUIC
you no longer have access to the hardware anyways? But you need to
document the custom sysfs nodes: Please document them in the
following file:

Documentation/ABI/testing/sysfs-class-power-ltc4162l

v5 is on its way with a description.

I currently don't have access to the hardware, so these changes were only compile-tested.

[...]

+static int ltc4162l_remove(struct i2c_client *client)
+{
+       struct ltc4162l_info *info = i2c_get_clientdata(client);
+
+       sysfs_remove_group(&info->charger->dev.kobj, &ltc4162l_attr_group);
+
+       return 0;
+}
power-supply core automatically removes the sysfs groups specified
in power_supply_config.attr_grp.

Ah, good catch, missed that.



-- Sebastian


--
Mike Looijmans

Reply via email to