On 1/27/21 8:16 PM, Can Guo wrote:
> In __ufshcd_issue_tm_cmd(), it is not right to use hba->nutrs + req->tag as
> the Task Tag in one TMR UPIU. Directly use req->tag as the Task Tag.
Why is the current code wrong and why is this patch the proper fix?
Please explain this in the patch description.
> + * blk_get_request() used here is only to get a free tag.
Please fix the word order in this comment ("blk_get_request() is used
here only to get a free tag").
> + ufshcd_release(hba);
> blk_put_request(req);
>
> - ufshcd_release(hba);
An explanation for this change is missing from the patch description.
Thanks,
Bart.
