[PATCH 03/16] media: i2c: rdacm20: Replace goto with a loop

[Jacopo Mondi]

During the camera module initialization the image sensor PID is read to
verify it can correctly be identified. The current implementation is
rather confused and uses a loop implemented with a label and a goto.

Replace it with a more compact for() loop.

No functional changes intended.

Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org>
---
 drivers/media/i2c/rdacm20.c | 27 ++++++++++-----------------
 1 file changed, 10 insertions(+), 17 deletions(-)

diff --git a/drivers/media/i2c/rdacm20.c b/drivers/media/i2c/rdacm20.c
index 4d9bac87cba8..6504ed0bd3bc 100644
--- a/drivers/media/i2c/rdacm20.c
+++ b/drivers/media/i2c/rdacm20.c
@@ -59,6 +59,8 @@
  */
 #define OV10635_PIXEL_RATE             (44000000)
 
+#define OV10635_PID_TIMEOUT            3
+
 static const struct ov10635_reg {
        u16     reg;
        u8      val;
@@ -452,7 +454,7 @@ static const struct v4l2_subdev_ops rdacm20_subdev_ops = {
 
 static int rdacm20_initialize(struct rdacm20_device *dev)
 {
-       unsigned int retry = 3;
+       unsigned int i;
        int ret;
 
        /* Verify communication with the MAX9271: ping to wakeup. */
@@ -501,23 +503,14 @@ static int rdacm20_initialize(struct rdacm20_device *dev)
                return ret;
        usleep_range(10000, 15000);
 
-again:
-       ret = ov10635_read16(dev, OV10635_PID);
-       if (ret < 0) {
-               if (retry--)
-                       goto again;
-
-               dev_err(dev->dev, "OV10635 ID read failed (%d)\n",
-                       ret);
-               return -ENXIO;
+       for (i = 0; i < OV10635_PID_TIMEOUT; ++i) {
+               ret = ov10635_read16(dev, OV10635_PID);
+               if (ret == OV10635_VERSION)
+                       break;
+               usleep_range(1000, 2000);
        }
-
-       if (ret != OV10635_VERSION) {
-               if (retry--)
-                       goto again;
-
-               dev_err(dev->dev, "OV10635 ID mismatch (0x%04x)\n",
-                       ret);
+       if (i == OV10635_PID_TIMEOUT) {
+               dev_err(dev->dev, "OV10635 ID read failed (%d)\n", ret);
                return -ENXIO;
        }
 
-- 
2.30.0