* Michael Opdenacker <[EMAIL PROTECTED]> wrote: > obj-$(CONFIG_PARAVIRT) += paravirt_32.o > -obj-y += pcspeaker.o > - > obj-$(CONFIG_SCx200) += scx200_32.o > > +ifdef CONFIG_INPUT_PCSPKR > + obj-y += pcspeaker.o > +endif
why didnt you make this: obj-$(CONFIG_INPUT_PCSPKR) += pcspeaker.o ? Your patch looks fine to me otherwise, obviously if someone disables PCSPKR intentionally in the .config, the kernel should just do that. Could you resend it with the above thing fixed, and against x86.git#mm? The x86.git coordinates are at: http://redhat.com/~mingo/x86.git/README Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
