On 01/18/2008 01:29 PM, Ingo Molnar wrote: >> perhaps the right solution would be to only build it in if >> CONFIG_PCSPEAKER is "y" or "m". I.e. your original patch? >> > > i've added your patch to x86.git - see below. > Many thanks Ingo! > Index: linux-x86.q/arch/x86/kernel/Makefile > =================================================================== > --- linux-x86.q.orig/arch/x86/kernel/Makefile > +++ linux-x86.q/arch/x86/kernel/Makefile > @@ -68,7 +68,10 @@ obj-$(CONFIG_MGEODE_LX) += geode_32.o m > > obj-$(CONFIG_VMI) += vmi_32.o vmiclock_32.o > obj-$(CONFIG_PARAVIRT) += paravirt.o paravirt_patch_$(BITS).o > + > +ifdef CONFIG_INPUT_PCSPKR > obj-y += pcspeaker.o > +endif > > obj-$(CONFIG_SCx200) += scx200_32.o > However, wouldn't the Makefile look nicer if we introduced a CONFIG_PCSPEAKER setting as in the mips platform? We would just have:
obj-$(CONFIG_PCSPEAKER) += pcspeaker.o I can propose a corresponding patch, and I'd suggest to make CONFIG_PCSPEAKER depend on CONFIG_EMBEDDED. Thanks again! :-) Michael. -- Michael Opdenacker, Free Electrons Free Embedded Linux Training Materials on http://free-electrons.com/training (More than 1500 pages!) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
