On Fri, 2008-01-18 at 14:03 +0100, Michael Opdenacker wrote: > However, wouldn't the Makefile look nicer if we introduced a > CONFIG_PCSPEAKER setting as in the mips platform? We would just have: > > obj-$(CONFIG_PCSPEAKER) += pcspeaker.o
Yes, that would be cleaner. Not worth it for just x86, but there are about 6 other arches that use CONFIG_INPUT_PCSPKR. Do that in one patch on top of this one and send it to Andrew (who will pull the above into his tree from Ingo shortly). > I can propose a corresponding patch, and I'd suggest to make > CONFIG_PCSPEAKER depend on CONFIG_EMBEDDED. No, don't. It's fine the way it is. If INPUT_PCSPKR isn't set, we don't support the speaker, end of story. Also, bear in mind that there is a fair amount of lower-hanging fruit than this, so bouncing a bunch of patches back and forth to make this perfect is not the best use of people's time. -- Mathematics is the supreme nostalgia of our time. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
