On 31/03/21 23:08, Ben Gardon wrote:
+ if (is_tdp_mmu_enabled(kvm))
+ kvm_tdp_mmu_invalidate_roots(kvm);
+
/*
* Toggle mmu_valid_gen between '0' and '1'. Because slots_lock is
* held for the entire duration of zapping obsolete pages, it's
@@ -5451,9 +5454,6 @@ static void kvm_mmu_zap_all_fast(struct kvm *kvm)
kvm_zap_obsolete_pages(kvm);
- if (is_tdp_mmu_enabled(kvm))
- kvm_tdp_mmu_zap_all(kvm);
-
This is just cosmetic, but I'd prefer to keep the call to
kvm_tdp_mmu_invalidate_roots at the original place, so that it's clear
in the next patch that it's two separate parts because of the different
locking requirements.
Paolo
