Hi Yu,
Yu Kuai <yuku...@huawei.com> wrote on Thu, 8 Apr 2021 19:15:14 +0800:
> Fix to return a negative error code from the error handling
> case instead of 0, as done elsewhere in this function.
>
> Reported-by: Hulk Robot <hul...@huawei.com>
> Signed-off-by: Yu Kuai <yuku...@huawei.com>
> ---
> drivers/mtd/devices/phram.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mtd/devices/phram.c b/drivers/mtd/devices/phram.c
> index 5b04ae6c3057..6ed6c51fac69 100644
> --- a/drivers/mtd/devices/phram.c
> +++ b/drivers/mtd/devices/phram.c
> @@ -270,6 +270,7 @@ static int phram_setup(const char *val)
> if (len == 0 || erasesize == 0 || erasesize > len
> || erasesize > UINT_MAX || rem) {
> parse_err("illegal erasesize or len\n");
> + ret = -EINVAL;
> goto error;
> }
>
It looks like you're doing the opposite of what you say.
Thanks,
Miquèl
