Hi Yu, Yu Kuai <[email protected]> wrote on Thu, 8 Apr 2021 21:38:12 +0800:
> Return a negative error code from the error handling case instead > of 0, as done elsewhere in this function. > > Reported-by: Hulk Robot <[email protected]> > Signed-off-by: Yu Kuai <[email protected]> > --- > drivers/mtd/devices/phram.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/mtd/devices/phram.c b/drivers/mtd/devices/phram.c > index 5b04ae6c3057..6ed6c51fac69 100644 > --- a/drivers/mtd/devices/phram.c > +++ b/drivers/mtd/devices/phram.c > @@ -270,6 +270,7 @@ static int phram_setup(const char *val) > if (len == 0 || erasesize == 0 || erasesize > len > || erasesize > UINT_MAX || rem) { > parse_err("illegal erasesize or len\n"); > + ret = -EINVAL; > goto error; > } > Actually I don't know why but I overlooked the change. I thought you were removing the ret = line, sorry about that. Anyway, I prefer the new wording so I'll apply the v2. Thanks, Miquèl
