On Fri, May 22, 2026 at 09:00:46AM +0200, Daniel Vacek wrote: > Hi Eric, > > This is just a gentle ping. > I was wondering if you had a chance to look at this version? > I believe all your previous feedback has been addressed and this > version is solid. > Please, let me know your thoughts. > > Regards, > Daniel
It's been really hard to find time to review this huge patchset. I've started going through it and will try to leave comments next week. In the mean time it would be really helpful if you went through the Sashiko reviews (https://sashiko.dev/#/patchset/20260513085340.3673127-1-neelx%40suse.com) and address the ones that make sense to. It found 93 issues including 16 critical ones, which is kind of a lot. Some of them are the same things I'm noticing already. Same for the issue that Christoph noticed where new devices can be added; Sashiko had already found that too. If I'm going to have to use my limited human review time to point out issues that were already found, that's not a great use of time. I also don't see any information about how this was tested (and will continue to be tested in the future). - Eric
