On 09/05/2012 09:15 AM, Tejun Heo wrote:
> On Sun, Sep 02, 2012 at 12:28:28AM +0800, Lai Jiangshan wrote:
>> Currently is single pass, we can wait on idle_done instead wait on
>> rebind_hold.
>> So we can remove rebind_hold and make the code simpler.
>
> As I wrote before, in general, I do like this approach; however, the
> implementation in this series seems to make the code longer, which
> kinda defeats its purpose of simplifying the implementation. It could
> be because the series is mixing fixes with restructuring.
> Can you
> please re-spin the restructuring part once fixes are settled? Let's
> see if that actually makes things simpler.
OK for me.
Patch 5: -4
Patch 6: -9 Patch 5,6 simplify idle rebind(benefit from Patch 2)
Patch 7: +31
Patch 8: +14 Patch 7,8 make busy worker wait idle worker's rebinding
Patch 9: -7
Patch 10: -13 Patch 9,10 single pass
total: +11 single pass allows us clean up more, example narrow the
critical
critical section of manage_mutex. I will add it in next
round.
thank,
Lai
>
> Thanks!
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
