On Thu, Sep 06, 2012 at 10:38:40PM -0400, Huang Shijie wrote: > After set the AUART_CTRL0_CLKGATE, the UART will gate all the clocks off. > So the following line will not take effect. > ................................................................ > writel(AUART_INTR_RXIEN | AUART_INTR_RTIEN | AUART_INTR_CTSMIEN, > u->membase + AUART_INTR_CLR); > ................................................................ > > To fix this issue, the patch moves this gate-off line to > the end of setting registers. > > Signed-off-by: Huang Shijie <shij...@gmail.com>
Acked-by: Shawn Guo <shawn....@linaro.org> Are you experiencing any user visible problem with this bug? Regards, Shawn > --- > drivers/tty/serial/mxs-auart.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/tty/serial/mxs-auart.c b/drivers/tty/serial/mxs-auart.c > index dafeef2..ea5f888 100644 > --- a/drivers/tty/serial/mxs-auart.c > +++ b/drivers/tty/serial/mxs-auart.c > @@ -457,11 +457,11 @@ static void mxs_auart_shutdown(struct uart_port *u) > > writel(AUART_CTRL2_UARTEN, u->membase + AUART_CTRL2_CLR); > > - writel(AUART_CTRL0_CLKGATE, u->membase + AUART_CTRL0_SET); > - > writel(AUART_INTR_RXIEN | AUART_INTR_RTIEN | AUART_INTR_CTSMIEN, > u->membase + AUART_INTR_CLR); > > + writel(AUART_CTRL0_CLKGATE, u->membase + AUART_CTRL0_SET); > + > clk_disable_unprepare(s->clk); > } > > -- > 1.7.4.4 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
