On Fri, Sep 07, 2012 at 10:33:07AM +0800, Huang Shijie wrote: > We call the get_device() in the mxs_auart_probe(). > For the balance of the reference count, we should put the > device in the mxs_auart_remove() or in the error path of > probe. > > Signed-off-by: Huang Shijie <b32...@freescale.com>
Acked-by: Shawn Guo <shawn....@linaro.org> > --- > drivers/tty/serial/mxs-auart.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/drivers/tty/serial/mxs-auart.c b/drivers/tty/serial/mxs-auart.c > index 3a667ee..203e512 100644 > --- a/drivers/tty/serial/mxs-auart.c > +++ b/drivers/tty/serial/mxs-auart.c > @@ -781,6 +781,7 @@ out_free_irq: > auart_port[pdev->id] = NULL; > free_irq(s->irq, s); > out_free_clk: > + put_device(s->dev); > clk_put(s->clk); > out_free: > kfree(s); > @@ -796,6 +797,7 @@ static int __devexit mxs_auart_remove(struct > platform_device *pdev) > > auart_port[pdev->id] = NULL; > > + put_device(s->dev); > clk_put(s->clk); > free_irq(s->irq, s); > kfree(s); > -- > 1.7.0.4 > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
