Il 20/11/2012 00:48, David Miller ha scritto:
From: Paolo Valente <paolo.vale...@unimore.it>
Date: Mon, 12 Nov 2012 17:48:33 +0100
[This patch received positive feedback from Stephen Hemminger ("put in
net-next"), but no further feedback or decision. So I am (re)sending
an updated version of it. The only differences with respect to the
previous version are the support for TSO/GSO (taken from QFQ), and a
hopefully improved description.]
Can you rearrange the logic so that the compiler doesn't emit this
warning?
In file included from net/sched/sch_qfq.c:18:0:
net/sched/sch_qfq.c: In function ‘qfq_dequeue’:
include/net/sch_generic.h:480:15: warning: ‘skb’ may be used uninitialized in
this function [-Wmaybe-uninitialized]
net/sched/sch_qfq.c:1007:18: note: ‘skb’ was declared here
You and I both know that SKB will be initialized at this point, but
the compiler can't see it clearly enough.
Unfortunately I could not reproduce the warning (with
gcc-4.7 -Wmaybe-uninitialized). I am however about to send a new version
with skb initialized to NULL. I hope that this fix properly addresses
this issue.
Thanks.
--
-----------------------------------------------------------
| Paolo Valente | |
| Algogroup | |
| Dip. Ing. Informazione | tel: +39 059 2056318 |
| Via Vignolese 905/b | fax: +39 059 2056129 |
| 41125 Modena - Italy | |
| home: http://algo.ing.unimo.it/people/paolo/ |
-----------------------------------------------------------
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
