On 05/10, Lucas De Marchi wrote: > > On Fri, May 10, 2013 at 2:35 PM, Oleg Nesterov <o...@redhat.com> wrote: > > On 05/10, Oleg Nesterov wrote: > >> > >> > > -char modprobe_path[KMOD_PATH_LEN] = "/sbin/modprobe"; > >> > > +char modprobe_path[KMOD_PATH_LEN] = "/sbin/modprobe -q --"; > >> > >> No. This is incompatible change, we shouldn't do this. > > > > Exactly. This can break a distro which writes to sys/kernel/modprobe. > > > > And if we do not do this, you can simply make a single trivial patch > > which does ... > > that it all. (or perhaps a kernel parameter makes more sense). > > > > Yes, this doesn't allow to pass the additional arguments, but is it > > that important? > > Yes, because I don't want to simply change the binary to use, I want > to be able to use a general "kmod" binary that accept a command like > "load". Next version of kmod will accept things like this (see the > commit message in patch 3/3):
Well, but a link to the binary which checks argv[0] or a trivial executable which simply execs "kmod load" looks like the simple workaround. And this doesn't need to recompile the kernel. Lucas, I simply do not know... Andrew, Rusty, what do you think? Can we do the change above? Do we really want CONFIG_MODPROBE_PATH or a kernel parameter ? Oleg. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/