On 05/11, Lucas De Marchi wrote: > > On Fri, May 10, 2013 at 2:10 PM, Oleg Nesterov <o...@redhat.com> wrote: > > > >> > -char modprobe_path[KMOD_PATH_LEN] = "/sbin/modprobe"; > >> > +char modprobe_path[KMOD_PATH_LEN] = "/sbin/modprobe -q --"; > > > > No. This is incompatible change, we shouldn't do this. > > But then what option do we have? I don't think any distro writing to > sysctl would stop working without "-q --".
Who knows? Again, I won't argue, I simply do not know. But this is incompatible change. > And if they are indeed > using this during boot, I think they would be much safer to just > change to set this at compile time like this patch is trying to do. Personally I think that "compile time" is not the best choice, but I won't argue. > Otherwise, the options are really ugly: > > 1) always give "-q --" by putting this on the kasprintf() call: > kasprintf(GFP_KERNEL, "%s -q -- %s", modprobe_command, module_name). > 2) provide a proc_dostring_modprobe, which ensures "-q --" is appended > to the provided path Agreed, both options do not look nice. Lucas. I will be happy to resend the argv_split/call_modprobe changes, but I can't judge whether we can/want do this. Oleg. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/