On 07/12/13 05:10, Stephen Boyd wrote: > On 07/12, Javi Merino wrote: >> I agree, we should drop the check. It's annoying in uniprocessors and >> unlikely to be found in the real world unless your gic entry in the dt >> is wrong. >> > Ok. How about this?
Any comments? > > ----8<----- > Subject: [PATCH v2] irqchip: gic: Don't complain in gic_get_cpumask() > > In a uniprocessor implementation the interrupt processor targets > registers are read-as-zero/write-ignored (RAZ/WI). Unfortunately > gic_get_cpumask() will print a critical message saying > > GIC CPU mask not found - kernel will fail to boot. > > if these registers all read as zero, but there won't actually be > a problem on uniprocessor systems and the kernel will boot just > fine. Remove this check because if you're on a multiprocessor > system it's unlikely to be printed unless your DT is wrong or > your hardware is broken. > > Cc: Nicolas Pitre <n...@linaro.org> > Cc: Russell King <rmk+ker...@arm.linux.org.uk> > Cc: Javi Merino <javi.mer...@arm.com> > Signed-off-by: Stephen Boyd <sb...@codeaurora.org> > --- > drivers/irqchip/irq-gic.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/irqchip/irq-gic.c b/drivers/irqchip/irq-gic.c > index 19ceaa60..4fbcea9 100644 > --- a/drivers/irqchip/irq-gic.c > +++ b/drivers/irqchip/irq-gic.c > @@ -368,9 +368,6 @@ static u8 gic_get_cpumask(struct gic_chip_data *gic) > break; > } > > - if (!mask) > - pr_crit("GIC CPU mask not found - kernel will fail to boot.\n"); > - > return mask; > } > -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/