On Tue, Aug 13, 2013 at 12:00:39PM +0300, Dan Carpenter wrote: > > > > Use the wrapper function for retrieving the platform data instead of > > > > accessing dev->platform_data directly. > > > > > > Um.. what is the benefit or rationale of this patch? > > > > CC'ed Joe Perches, Dan Carpenter > > > > Hi Anton Vorontsov, > > > > Usually, using the wrapper function makes the code simpler. > > Also, it make the code more readable. > > Since people are asking my opinion, then yes using > dev_get_platdata() as intended is better than open coding. It's a > coding standard thing.
I don't see any immediate benefit of applying this patch... It does not fix anything now or in the near future (or we are about to add something into dev_get_platdata() wrapper, or get rid of dev.platform_data member? Any plans for this? Then it should be in the commit message.) Without any plans to actually use the wrapper the patch is just a churn [that might result into patch conflicts that I'll have to deal with], so I'll refrain from applying it. Thanks, Anton -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
