On Fri, Sep 27, 2013 at 11:45:48AM +0100, Oussama Ghorbel wrote: > The ip6_tunnel.c module would be then dependent on ip_tunnel.c and may > be it would not be good thing?
It could just be a static inline in some shared header. So there would be no compile-time dependency. > As I have check in v3.10 there is no call from ip6_tunnel to ip_tunnel... > > For information, there is no check for the maximum MTU for ipv4 in the > patch as this is not done for ipv6. I understand, but it would be better to limit the MTU here. There is a (non-jumo) IPV6_MAXPLEN constant. Looking through the source it seems grev6 does actually check this, so it would not hurt adding them here, too. Otherwise, I think your patch is fine. Greetings, Hannes -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
