On Mon, 2013-09-30 at 13:29 -0700, Andi Kleen wrote: > From: Andi Kleen <[email protected]> > > eee_get_cur assumes that the output data is already zeroed. It can > read-modify-write the advertised field: > > if (ipcnfg & E1000_IPCNFG_EEE_100M_AN) > 2594 edata->advertised |= ADVERTISED_100baseT_Full; > > This is ok for the normal ethtool eee_get call, which always > zeroes the input data before. > > But eee_set_cur also calls eee_get_cur and it did not zero the input > field. Later on it then compares agsinst the field, which can contain > partial > stack garbage. > > Zero the input field in eee_set_cur() too. > > Cc: [email protected] > Cc: [email protected] > Signed-off-by: Andi Kleen <[email protected]> > --- > drivers/net/ethernet/intel/igb/igb_ethtool.c | 2 ++ > 1 file changed, 2 insertions(+)
Acked-by: Jeff Kirsher <[email protected]>
signature.asc
Description: This is a digitally signed message part
