From: Andi Kleen <a...@firstfloor.org> Date: Mon, 30 Sep 2013 13:29:08 -0700
> From: Andi Kleen <a...@linux.intel.com> > > eee_get_cur assumes that the output data is already zeroed. It can > read-modify-write the advertised field: > > if (ipcnfg & E1000_IPCNFG_EEE_100M_AN) > 2594 edata->advertised |= ADVERTISED_100baseT_Full; > > This is ok for the normal ethtool eee_get call, which always > zeroes the input data before. > > But eee_set_cur also calls eee_get_cur and it did not zero the input > field. Later on it then compares agsinst the field, which can contain partial > stack garbage. > > Zero the input field in eee_set_cur() too. > > Cc: jeffrey.t.kirs...@intel.com > Cc: net...@vger.kernel.org > Signed-off-by: Andi Kleen <a...@linux.intel.com> Applied. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
