>
> >> If an administrator wants to use MEI, they can search the logs for
> >> 'mei'. Otherwise they don't need a glaring reminder that their
> >> hardware doesn't actually support MEI.
> >>
> >> Signed-off-by: Andy Lutomirski <l...@amacapital.net>
> >> ---
> >> drivers/misc/mei/pci-me.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/misc/mei/pci-me.c b/drivers/misc/mei/pci-me.c
> >> index ddadd08..809021e 100644
> >> --- a/drivers/misc/mei/pci-me.c
> >> +++ b/drivers/misc/mei/pci-me.c
> >> @@ -127,7 +127,7 @@ static int mei_me_probe(struct pci_dev *pdev, const
> >> struct pci_device_id *ent)
> >>
> >> if (!mei_me_quirk_probe(pdev, ent)) {
> >> err = -ENODEV;
> >> - goto end;
> >> + return err; /* No point in logging an error. */
> >> }
> >
> >
> > I would like to have at least some info/debug message logged,
> > the issue was discovered on specific DELL machines and there is a little
> > worry
> > that on some systems it can be false positive.
>
> mei_me_quirk_probe logs "Device doesn't have valid ME Interface\n".
Grrr, right!
ACK, though it would be simpler just to:
if (!mei_me_quirk_probe(pdev, ent))
return -ENODEV;
Even this is trivial fix I would prefer it will go through Greg's char-misc
tree, as this is what I'm rebasing on.
Thanks
Tomas
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
