Rob, On Tue, Apr 22, 2014 at 01:54:33PM -0500, Rob Herring wrote: > On Tue, Apr 22, 2014 at 1:47 PM, Rob Herring <robherri...@gmail.com> wrote: > > On Tue, Apr 22, 2014 at 10:38 AM, Antoine Ténart > > <antoine.ten...@free-electrons.com> wrote: > >> Add support for the Berlin SoCs AHCI SATA controller allowing to > >> interface with devices like external hard drives. > > One more thing. > > >> + nports = readl(hpriv->mmio + HOST_PORTS_IMPL); > >> + > >> + /* force_map is modified only if the property is found */ > >> + of_property_read_u32(np, "marvell,force-port-map", &force_map); > > This property does not appear to be documented.
I'll update it regarding Sebastian comments, or maybe drop it if it is possible to enable each port individually. > > >> + if (force_map) > >> + nports = force_map; > > You don't need this as your comment says, you can just do: > > of_property_read_u32(np, "marvell,force-port-map", &nports); > > nports will only be changed if property is present. Sure. Thanks! Antoine -- Antoine Ténart, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
