On Thu, Apr 24, 2014 at 09:34:57PM +0900, Chanwoo Choi wrote: > This patch use devm_extcon_dev_allocate() to simplify the memory control > of extcon device. > > Cc: Graeme Gregory <[email protected]> > Cc: Kishon Vijay Abraham I <[email protected]> > Cc: Felipe Balbi <[email protected]> > Cc: Samuel Ortiz <[email protected]> > Cc: Lee Jones <[email protected]> > Signed-off-by: Chanwoo Choi <[email protected]> > Acked-by: Lee Jones <[email protected]>
Tested-by: Felipe Balbi <[email protected]> *BUT* you need to fix NULL vs ERR_PTR return in your code. The way this is, we can easily dereference an ERR_PTR because the code doesn't test for it. I suggest always returning valid pointer or ERR_PTR and avoid returning NULL at all. -- balbi
signature.asc
Description: Digital signature
