On Thu, Apr 24, 2014 at 11:47 PM, Felipe Balbi <ba...@ti.com> wrote: > On Thu, Apr 24, 2014 at 09:34:57PM +0900, Chanwoo Choi wrote: >> This patch use devm_extcon_dev_allocate() to simplify the memory control >> of extcon device. >> >> Cc: Graeme Gregory <g...@slimlogic.co.uk> >> Cc: Kishon Vijay Abraham I <kis...@ti.com> >> Cc: Felipe Balbi <ba...@ti.com> >> Cc: Samuel Ortiz <sa...@linux.intel.com> >> Cc: Lee Jones <lee.jo...@linaro.org> >> Signed-off-by: Chanwoo Choi <cw00.c...@samsung.com> >> Acked-by: Lee Jones <lee.jo...@linaro.org> > > Tested-by: Felipe Balbi <ba...@ti.com>
Thanks for your test. > > *BUT* you need to fix NULL vs ERR_PTR return in your code. The way this > is, we can easily dereference an ERR_PTR because the code doesn't test > for it. I suggest always returning valid pointer or ERR_PTR and avoid > returning NULL at all. OK, as my reply on other mail, I'll fix return type by using ERR_PTR instead of NULL. Thanks, Chanwoo Choi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
