On Thu, Apr 24, 2014 at 11:45 PM, Felipe Balbi <[email protected]> wrote: > On Thu, Apr 24, 2014 at 09:34:51PM +0900, Chanwoo Choi wrote: >> This patch use devm_extcon_dev_allocate() to simplify the memory control >> of extcon device. >> >> Signed-off-by: Chanwoo Choi <[email protected]> >> Reviewed-by: Krzysztof Kozlowski <[email protected]> >> --- >> drivers/extcon/extcon-max8997.c | 5 ++--- >> 1 file changed, 2 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/extcon/extcon-max8997.c >> b/drivers/extcon/extcon-max8997.c >> index 804a446..e2ee2f5 100644 >> --- a/drivers/extcon/extcon-max8997.c >> +++ b/drivers/extcon/extcon-max8997.c >> @@ -699,8 +699,7 @@ static int max8997_muic_probe(struct platform_device >> *pdev) >> } >> >> /* External connector */ >> - info->edev = devm_kzalloc(&pdev->dev, sizeof(struct extcon_dev), >> - GFP_KERNEL); >> + info->edev = devm_extcon_dev_allocate(&pdev->dev, >> max8997_extcon_cable); >> if (!info->edev) { > > and here you never check for IS_ERR(info->evdev) > > NAK > > I suspect all following patches have the same defect.
OK, I'll use IS_ERR() instead of checking NULL. Thanks, Chanwoo Choi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
