On Wed, 2014-04-30 at 14:06 -0700, Davidlohr Bueso wrote: > > > > > > > > > > if (count == RWSEM_WAITING_BIAS) > > > > > old = cmpxchg(&sem->count, count, count + > > > > > RWSEM_ACTIVE_BIAS); > > > > > else > > > > > old = cmpxchg(&sem->count, count, count + > > > > > RWSEM_ACTIVE_WRITE_BIAS); > > > > > > > > I think I simply mis-typed it; shouldn't both cases be > > > > RWSEM_ACTIVE_WRITE_BIAS ? > > > > > > Yeah, we should just write it as > > > old = cmpxchg(&sem->count, count, > > > RWSEM_ACTIVE_WRITE_BIAS); > > > > Oops, I mean > > old = cmpxchg(&sem->count, count, count + > > RWSEM_ACTIVE_WRITE_BIAS); > > > > for count == 0, we need sem->count to be RWSEM_ACTIVE_WRITE_BIAS, > > for count == RWSEM_WAITING_BIAS, we need sem->count to be > > RWSEM_WAITING_BIAS + RWSEM_ACTIVE_WRITE_BIAS > > Yep, I had just noticed this. Peter's original suggestion was correct, > just needed to change RWSEM_ACTIVE_BIAS for RWSEM_ACTIVE_WRITE_BIAS. >
Yes, I think we are all on the same page now. Tim -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
