On Fri, 11 Jul 2014 21:06:50 +0200 Oleg Nesterov <[email protected]> wrote:
> alloc_trace_uprobe() sets TRACE_EVENT_FL_USE_CALL_FILTER for unknown > reason and this is simply wrong. The reason is not unknown. The reason is "cut and paste". -- Steve > Fortunately this has no effect because > register_uprobe_event() clears call->flags after that. > > Kill both. This trace_uprobe was kzalloc'ed and we realy on this fact > anyway. > > Signed-off-by: Oleg Nesterov <[email protected]> > --- > kernel/trace/trace_uprobe.c | 3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) > > diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c > index 3c9b97e..33ff6a2 100644 > --- a/kernel/trace/trace_uprobe.c > +++ b/kernel/trace/trace_uprobe.c > @@ -265,7 +265,6 @@ alloc_trace_uprobe(const char *group, const char *event, > int nargs, bool is_ret) > if (is_ret) > tu->consumer.ret_handler = uretprobe_dispatcher; > init_trace_uprobe_filter(&tu->filter); > - tu->tp.call.flags |= TRACE_EVENT_FL_USE_CALL_FILTER; > return tu; > > error: > @@ -1292,7 +1291,7 @@ static int register_uprobe_event(struct trace_uprobe > *tu) > kfree(call->print_fmt); > return -ENODEV; > } > - call->flags = 0; > + > call->class->reg = trace_uprobe_register; > call->data = tu; > ret = trace_add_event_call(call); -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
