On Sat, 2014-10-11 at 18:31 +0200, Rasmus Wriedt Larsen wrote: > * fix multiple quoted string split across lines style issues > * change printk(KERN_NOTICE to pr_notice > * insert spaces after , in function call [] > diff --git a/init/calibrate.c b/init/calibrate.c [] > @@ -160,9 +158,7 @@ static unsigned long calibrate_delay_direct(void) > > } > > - printk(KERN_NOTICE "calibrate_delay_direct() failed to get a good " > - "estimate for loops_per_jiffy.\nProbably due to long platform " > - "interrupts. Consider using \"lpj=\" boot option.\n"); > + pr_notice("calibrate_delay_direct() failed to get a good estimate for > loops_per_jiffy.\nProbably due to long platform interrupts. Consider using > \"lpj=\" boot option.\n");
This would be better on 2 lines: pr_notice("calibrate_delay_direct() failed to get a good estimate for loops_per_jiffy.\n" "Probably due to long platform interrupts. Consider using \"lpj=\" boot option.\n"); The grammar is poor though and this could be better phrased. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/