On Fri, 2015-03-13 at 12:37 +0000, Ingo Molnar wrote: > * Toshi Kani <[email protected]> wrote: : > > + /* Look in fixed ranges. Just return the type as per start */ > > + if (mtrr_state.have_fixed && (start < 0x100000)) { > > + int idx; > > + > > + if (start < 0x80000) { > > + idx = 0; > > + idx += (start >> 16); > > + return mtrr_state.fixed_ranges[idx]; > > + } else if (start < 0xC0000) { > > + idx = 1 * 8; > > + idx += ((start - 0x80000) >> 14); > > + return mtrr_state.fixed_ranges[idx]; > > + } else { > > + idx = 3 * 8; > > + idx += ((start - 0xC0000) >> 12); > > + return mtrr_state.fixed_ranges[idx]; > > + } > > + } > > So why not put this into a separate helper function - named > mtrr_type_lookup_fixed()? It has little relation to variable ranges.
Sounds good. I will update as suggested. > > + > > + /* > > + * Look in variable ranges > > + * Look of multiple ranges matching this address and pick type > > + * as per MTRR precedence > > + */ > > + if (!(mtrr_state.enabled & 2)) > > + return mtrr_state.def_type; > > + > > type = __mtrr_type_lookup(start, end, &partial_end, &repeat); > > And this then should be named mtrr_type_lookup_variable() or so? Will do as well. I will send out a new version today since I won't be able to update the patchset next week. Thanks, -Toshi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
