On Sun, Mar 15, 2015 at 09:04:36PM +0100, Oleg Nesterov wrote: > But please note that it is not only used after the failure. > See handle_signal() and the first drop_init_fpu() in > __restore_xstate_sig().
Yeah, that's why I said "In the most places it is used..." > I think its name is confusing a bit... Yeah, the "init" aspect affects only the eager case... How about we call this function fpu_reset_state() instead? This way it doesn't really need to be documented what it does - it simply resets the FPU state. And resetting is what we do in all call sites so the usage dictates the name and then "drop" can be differentiated from "reset" as "drop" is only a part of the "reset" operation on an FPU state. And so on and so on... Hmmm? -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. -- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/