On Thu, Apr 2, 2015 at 11:13 AM, Richard Weinberger <rich...@nod.at> wrote:
> + err = -ENOMEM; > + iobuf = kmalloc(mtd->erasesize, GFP_KERNEL); > + if (!iobuf) > + goto out; The error handling here does not look right. > + > + iobuf_orig = kmalloc(mtd->erasesize, GFP_KERNEL); > + if (!iobuf_orig) > + goto out; > + > + prandom_bytes_state(&rnd_state, iobuf_orig, mtd->erasesize); > + > + bit_flips = kcalloc(ebcnt, sizeof(unsigned long), GFP_KERNEL); > + if (!bit_flips) > + goto out; > + > + bbt = kzalloc(ebcnt, GFP_KERNEL); > + if (!bbt) > + goto out; > + > + err = mtdtest_scan_for_bad_eraseblocks(mtd, bbt, 0, ebcnt); > + if (err) > + goto out; > + > + pr_info("erasing and programming flash\n"); > + for (i = 0; i < ebcnt; ++i) { > + if (skip_blocks && i % skip_blocks != 0) > + continue; > + > + if (bbt[i]) > + continue; > + > + ret = mtdtest_erase_eraseblock(mtd, i); > + if (ret) { > + err = ret; > + goto out; > + } > + > + ret = mtdtest_write(mtd, i * mtd->erasesize, mtd->erasesize, > + iobuf_orig); > + if (ret) { > + err = ret; > + goto out; > + } > + > + ret = mtdtest_relax(); > + if (ret) > + goto out; > + } > + > + pr_info("starting read disturb test on every %ith block\n", > + skip_blocks); > + while (!ret) { > + for (i = 0; i < ebcnt; ++i) { > + if (skip_blocks && i % skip_blocks != 0) > + continue; > + > + if (bbt[i]) > + continue; > + > + ret = read_eraseblock_by_page(i, iteration); > + > + ret = mtdtest_relax(); > + if (ret) > + goto out; > + } > + > + iteration++; > + if (iteration % 1000 == 0) > + pr_info("iteration %lu started\n", iteration); > + } > + > + if (err) > + pr_info("finished with errors\n"); > + else > + pr_info("finished\n"); > + > +out: > + > + kfree(bit_flips); > + kfree(iobuf); > + kfree(iobuf_orig); > + kfree(bbt); ,as you have a single label to handle all the free's. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/