On Thu, Apr 2, 2015 at 11:33 AM, Richard Weinberger <rich...@nod.at> wrote:
> Why? Free()ing a NULL pointer is perfectly fine. > What did I miss? :) If the first 'iobuf = kmalloc(mtd->erasesize, GFP_KERNEL);' fails then you jump to the out label where you call 5 kfree() and then return the error. It would be much better just to return the error immediately in this case and add one label for each allocation error, so that it only kfree the previous successful allocations. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
