Am 02.04.2015 um 17:02 schrieb Fabio Estevam:
> On Thu, Apr 2, 2015 at 11:13 AM, Richard Weinberger <rich...@nod.at> wrote:
>
>> + ret = mtdtest_erase_eraseblock(mtd, i);
>> + if (ret) {
>> + err = ret;
>> + goto out;
>> + }
>
> Why not just do like this instead?
>
> err = mtdtest_erase_eraseblock(mtd, i);
> if (err)
> goto out;
>
>> +
>> + ret = mtdtest_write(mtd, i * mtd->erasesize, mtd->erasesize,
>> + iobuf_orig);
>> + if (ret) {
>> + err = ret;
>> + goto out;
>> + }
>
> Same here.
The real question is why did I use ret and err at all? ;)
This test is based on existing tests, thus it got copy&pasted.
I'll think about merging these two variables.
Thank for pointing this out.
>> + ret = mtdtest_relax();
>> + if (ret)
>> + goto out;
>
> Here you propagate the wrong error. You test for 'ret' and propagate 'err'.
This is by design. I don't want to print an error message if the test is
aborted.
mtdtest_relax() checks for that.
Thanks,
//richard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
