On Mon, Apr 13, 2015 at 06:40:35PM +0000, Hefty, Sean wrote: > > > - if (rdma_node_get_transport(ib_device->node_type) != > > RDMA_TRANSPORT_IB) > > > - return; > > > + int count = 0; > > > > I'm ok with this as an intermediate patch but going forward if we are > > going to > > have calls like > > > > static inline int cap_ib_cm_dev(struct ib_device *device) > > I would rather keep everything to checking per port, not per device. > Specifically, because we have code that does this:
Argee. I asked Michael for it and stand by it, the property is per-port, not per device. Having the per-device tests just muddles the logic, look at the trouble Sean notices in #10 when we are now forced to think of things clearly. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
