Tejun Heo <t...@kernel.org> writes:
> cfq_get_queue()'s control flow looks like the following.
>
> async_cfqq = NULL;
> cfqq = NULL;
>
> if (!is_sync) {
> ...
> async_cfqq = ...;
> cfqq = *async_cfqq;
> }
>
> if (!cfqq)
> cfqq = ...;
>
> if (!is_sync && !(*async_cfqq))
> ...;
>
> The only thing the local variable init, the second if, and the
> async_cfqq test in the third if achieves is to skip cfqq creation and
> installation if *async_cfqq was already non-NULL. This is needlessly
> complicated with different tests examining the same condition.
> Simplify it to the following.
>
> if (!is_sync) {
> ...
> async_cfqq = ...;
> cfqq = *async_cfqq;
> if (cfqq)
> goto out;
> }
>
> cfqq = ...;
>
> if (!is_sync)
> ...;
> out:
>
> Signed-off-by: Tejun Heo <t...@kernel.org>
> Cc: Vivek Goyal <vgo...@redhat.com>
> Cc: Arianna Avanzini <avanzini.aria...@gmail.com>
Acked-by: Jeff Moyer <jmo...@redhat.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
