Tejun Heo <[email protected]> writes: > * Some were accessing cic->cfqq[] directly. Always use cic_to_cfqq() > and cic_set_cfqq(). > > * check_ioprio_changed() doesn't need to verify cfq_get_queue()'s > return for NULL. It's always non-NULL. Simplify accordingly. > > This patch doesn't cause any functional changes. > > Signed-off-by: Tejun Heo <[email protected]> > Cc: Vivek Goyal <[email protected]> > Cc: Arianna Avanzini <[email protected]>
Looks good. I don't much like the "bool is_sync" function parameters. Calls to cic_to_cfqq, cic_set_cfqq, etc would be much easier to read if they took BLK_RW_SYNC and BLK_RW_ASYNC. Certainly not a problem with this patch, though, just a general observation. Reviewed-by: Jeff Moyer <[email protected]> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
