On Thu, 10 Sep 2015, Shraddha Barke wrote: > This patch replaces bit shifting on 1 with the BIT(x) macro > as it's extensively used by other function in this driver.
Don't use BIT in the mixed cases. julia > > This was done with coccinelle: > @@ int g; @@ > > -(1 << g) > +BIT(g) > > Signed-off-by: Shraddha Barke <shraddha.6...@gmail.com> > --- > drivers/staging/iio/cdc/ad7152.c | 20 ++++++++++---------- > 1 file changed, 10 insertions(+), 10 deletions(-) > > diff --git a/drivers/staging/iio/cdc/ad7152.c > b/drivers/staging/iio/cdc/ad7152.c > index 87110d9..ba44c0e 100644 > --- a/drivers/staging/iio/cdc/ad7152.c > +++ b/drivers/staging/iio/cdc/ad7152.c > @@ -41,30 +41,30 @@ > #define AD7152_REG_CFG2 26 > > /* Status Register Bit Designations (AD7152_REG_STATUS) */ > -#define AD7152_STATUS_RDY1 (1 << 0) > -#define AD7152_STATUS_RDY2 (1 << 1) > -#define AD7152_STATUS_C1C2 (1 << 2) > -#define AD7152_STATUS_PWDN (1 << 7) > +#define AD7152_STATUS_RDY1 BIT(0) > +#define AD7152_STATUS_RDY2 BIT(1) > +#define AD7152_STATUS_C1C2 BIT(2) > +#define AD7152_STATUS_PWDN BIT(7) > > /* Setup Register Bit Designations (AD7152_REG_CHx_SETUP) */ > -#define AD7152_SETUP_CAPDIFF (1 << 5) > +#define AD7152_SETUP_CAPDIFF BIT(5) > #define AD7152_SETUP_RANGE_2pF (0 << 6) > -#define AD7152_SETUP_RANGE_0_5pF (1 << 6) > +#define AD7152_SETUP_RANGE_0_5pF BIT(6) > #define AD7152_SETUP_RANGE_1pF (2 << 6) > #define AD7152_SETUP_RANGE_4pF (3 << 6) > #define AD7152_SETUP_RANGE(x) ((x) << 6) > > /* Config Register Bit Designations (AD7152_REG_CFG) */ > -#define AD7152_CONF_CH2EN (1 << 3) > -#define AD7152_CONF_CH1EN (1 << 4) > +#define AD7152_CONF_CH2EN BIT(3) > +#define AD7152_CONF_CH1EN BIT(4) > #define AD7152_CONF_MODE_IDLE (0 << 0) > -#define AD7152_CONF_MODE_CONT_CONV (1 << 0) > +#define AD7152_CONF_MODE_CONT_CONV BIT(0) > #define AD7152_CONF_MODE_SINGLE_CONV (2 << 0) > #define AD7152_CONF_MODE_OFFS_CAL (5 << 0) > #define AD7152_CONF_MODE_GAIN_CAL (6 << 0) > > /* Capdac Register Bit Designations (AD7152_REG_CAPDAC_XXX) */ > -#define AD7152_CAPDAC_DACEN (1 << 7) > +#define AD7152_CAPDAC_DACEN BIT(7) > #define AD7152_CAPDAC_DACP(x) ((x) & 0x1F) > > /* CFG2 Register Bit Designations (AD7152_REG_CFG2) */ > -- > 2.1.4 > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
