On Wed, 9 Sep 2015, Joe Perches wrote:
> On Thu, 2015-09-10 at 09:43 +0530, Shraddha Barke wrote: > > This patch replaces bit shifting on 1 with the BIT(x) macro > > as it's extensively used by other function in this driver. > [] > > diff --git a/drivers/staging/iio/resolver/ad2s1210.c > > b/drivers/staging/iio/resolver/ad2s1210.c > [] > > @@ -149,7 +149,7 @@ int ad2s1210_update_frequency_control_word(struct > > ad2s1210_state *st) > > int ret; > > unsigned char fcw; > > > > - fcw = (unsigned char)(st->fexcit * (1 << 15) / st->fclkin); > > + fcw = (unsigned char)(st->fexcit * BIT(15) / st->fclkin); > > Multiplying by a bit isn't very obvious. > Maybe just shift it. > > fcw = (unsigned char)((st->fexcit << 15) / st->fclkin); That looks nicer. Shraddha maybe you can find this issue elsewhere. julia -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
