From: Borislav Petkov <b...@suse.de> It is helpful when the crashkernel cmdline parsing routines actually say which character is the unrecognized one. Make them do so.
Cc: Andrew Morton <a...@linux-foundation.org> Cc: Andy Lutomirski <l...@amacapital.net> Cc: Baoquan He <b...@redhat.com> Cc: Dave Young <dyo...@redhat.com> Cc: "H. Peter Anvin" <h...@zytor.com> Cc: Ingo Molnar <mi...@kernel.org> Cc: jerry_hoem...@hp.com Cc: Jiri Kosina <jkos...@suse.cz> Cc: Joerg Roedel <jroe...@suse.de> Cc: Juergen Gross <jgr...@suse.com> Cc: Mark Salter <msal...@redhat.com> Cc: Thomas Gleixner <t...@linutronix.de> Cc: Vivek Goyal <vgo...@redhat.com> Cc: WANG Chao <chaow...@redhat.com> Cc: x86-ml <x...@kernel.org> Signed-off-by: Borislav Petkov <b...@suse.de> --- kernel/kexec_core.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/kernel/kexec_core.c b/kernel/kexec_core.c index 201b45327804..bd9f8a03cefa 100644 --- a/kernel/kexec_core.c +++ b/kernel/kexec_core.c @@ -1149,7 +1149,7 @@ static int __init parse_crashkernel_simple(char *cmdline, if (*cur == '@') *crash_base = memparse(cur+1, &cur); else if (*cur != ' ' && *cur != '\0') { - pr_warn("crashkernel: unrecognized char\n"); + pr_warn("crashkernel: unrecognized char: %c\n", *cur); return -EINVAL; } @@ -1186,12 +1186,12 @@ static int __init parse_crashkernel_suffix(char *cmdline, /* check with suffix */ if (strncmp(cur, suffix, strlen(suffix))) { - pr_warn("crashkernel: unrecognized char\n"); + pr_warn("crashkernel: unrecognized char: %c\n", *cur); return -EINVAL; } cur += strlen(suffix); if (*cur != ' ' && *cur != '\0') { - pr_warn("crashkernel: unrecognized char\n"); + pr_warn("crashkernel: unrecognized char: %c\n", *cur); return -EINVAL; } -- 2.3.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/