On 10/15/15 at 10:20am, Borislav Petkov wrote:
> From: Borislav Petkov <b...@suse.de>
>
> memblock_reserve() can fail but the crashkernel reservation code
> doesn't check that and this can lead the user into believing that the
> crashkernel region was actually reserved. Make sure we check that return
> value and we exit early with a failure message in the error case.
>
> Cc: Andrew Morton <a...@linux-foundation.org>
> Cc: Andy Lutomirski <l...@amacapital.net>
> Cc: Dave Young <dyo...@redhat.com>
> Cc: "H. Peter Anvin" <h...@zytor.com>
> Cc: Ingo Molnar <mi...@kernel.org>
> Cc: jerry_hoem...@hp.com
> Cc: Jiri Kosina <jkos...@suse.cz>
> Cc: Joerg Roedel <jroe...@suse.de>
> Cc: Juergen Gross <jgr...@suse.com>
> Cc: Mark Salter <msal...@redhat.com>
> Cc: Thomas Gleixner <t...@linutronix.de>
> Cc: WANG Chao <chaow...@redhat.com>
> Cc: x86-ml <x...@kernel.org>
> Signed-off-by: Borislav Petkov <b...@suse.de>
> ---
> arch/x86/kernel/setup.c | 12 ++++++++++--
> 1 file changed, 10 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
> index d4788719a1e2..3f75297d5fd0 100644
> --- a/arch/x86/kernel/setup.c
> +++ b/arch/x86/kernel/setup.c
> @@ -531,7 +531,11 @@ static int __init reserve_crashkernel_low(void)
> return -ENOMEM;
> }
>
> - memblock_reserve(low_base, low_size);
> + ret = memblock_reserve(low_base, low_size);
> + if (ret) {
> + pr_err("%s: Error reserving crashkernel low memblock.\n",
> __func__);
> + return ret;
> + }
>
Seems there's no checking for other callback to memblock_reserve in setup.c
Need another cleanup?
BTW, a further cleanup is reasonable to me, there's a lot of below patter:
memblock_find_in_range
error checking
memblock_reserve
error checking
So a new function memblock_reserve_in_range is reasonable.
Thanks
Dave
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
