On Thu, Oct 15, 2015 at 05:18:26PM +0800, Dave Young wrote: > Seems there's no checking for other callback to memblock_reserve in setup.c > Need another cleanup?
True story. It sure does. > BTW, a further cleanup is reasonable to me, there's a lot of below patter: > memblock_find_in_range > error checking > memblock_reserve > error checking > > So a new function memblock_reserve_in_range is reasonable. Well, in some of the callsites, the first "error checking" issues a specific message, depending on the subsystem. The following memblock_reserve() is mostly unchecked though. At least that should be fixed... -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/