On Mon, Mar 28, 2011 at 3:55 PM, Sakari Ailus <sakari.ai...@maxwell.research.nokia.com> wrote: > Hi,
Hi Sakari, [snip] > This is a bitmask containing the fault information for the flash. This > assumes the proposed V4L2 bit mask controls [5]; otherwise this would > likely need to be a set of controls. > > #define V4L2_FLASH_FAULT_OVER_VOLTAGE 0x00000001 > #define V4L2_FLASH_FAULT_TIMEOUT 0x00000002 > #define V4L2_FLASH_FAULT_OVER_TEMPERATURE 0x00000004 > #define V4L2_FLASH_FAULT_SHORT_CIRCUIT 0x00000008 Sorry for bringing this a bit late. As we already talked directly, IMO (1 << 0), (1 << 1), ... could have a better readability to expose how you want to define an expand these macros. Br, David Cohen -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
