Jason, While I do think supporting the trap would be a great idea going forward, I don't see any reason why it couldn't be combined with this patch when we figure out how to detect the hostname change.
For example, it would be great for me as a developer to be able to flag a group of machines as being dedicated to me, by setting their node descriptions to "%h: %d Mike's MPI Testbed" or similar. I could echo that into the node description at boot time and, if the host name changes afterwards, still have a trap triggered (somehow) to inform the SM of the change. -----Original Message----- From: Jason Gunthorpe [mailto:jguntho...@obsidianresearch.com] Sent: Wednesday, February 23, 2011 12:42 AM To: Roland Dreier Cc: Mike Heinz; linux-rdma@vger.kernel.org Subject: Re: [PATCH 0/2] Improved node descriptions On Tue, Feb 22, 2011 at 04:03:29PM -0800, Roland Dreier wrote: > On Tue, Feb 22, 2011 at 3:43 PM, Jason Gunthorpe > <jguntho...@obsidianresearch.com> wrote: > > Doing it in userspace makes generating the node description changed > > trap simpler? > > Hmm... how many places can do sethostname()? Seems easier to > catch in the kernel than hook every place in userspace. (Although > there's no kernel hook right now) I do agree it would be good to > have some idea of how we could generate the "node desc changed" > trap at appropriate times. Wasn't thinking about 100% perfection, just if DHCP is the concern it shouldn't be hard to hook that one place. > > I just wonder if this is a big pain to do right, what about charsets, IDN, > > and ugly details like that? > > Does anyone expect to care about non-ASCII node descs? > What can we sensibly do except take what we're given? node desc is UTF-8, hostname is IDNA, a conversion is required, see RFC 3490. Does anyone care? Who knows, but very pedantically it is wrong to just copy the host name byte by byte. I only mention it to point out that it is trivial to do what Mike did, somewhat harder to do % escaping like you suggest and solve the multiple HCA problem, harder still to trap sethostname() and generate a trap, and extra special hard to correctly handle character sets on top of all that. :) So, is it still trivial to do it in the kernel? Jason This message and any attached documents contain information from QLogic Corporation or its wholly-owned subsidiaries that may be confidential. If you are not the intended recipient, you may not read, copy, distribute, or use this information. If you have received this transmission in error, please notify the sender immediately by reply e-mail and then delete this message. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
