Originally I had xrc support in rxe but there was nothing in Roland's tree to support it so I stripped it out. I was experimenting with congestion notification to see if there was a way to slow down spewing by fast Ethernet devices but that wasn't working, also all the MAD support was stripped out. In the end the only thing left was the constants and entries in the opcode table in rxe_opcode.c which as you say are not used elsewhere. I think it is reasonable to have a complete set of opcodes somewhere.
I want to eventually complete the IB transport parts of the driver although they are not used by RoCE. They would be useful for a soft IB implementation with say an FPGA based MAC/PHY. The long term goal is to have a complete reference implementation of the IB Architecture. > -----Original Message----- > From: bart.vanass...@gmail.com [mailto:bart.vanass...@gmail.com] On > Behalf Of Bart Van Assche > Sent: Monday, August 15, 2011 4:13 AM > To: rpear...@systemfabricworks.com > Cc: linux-rdma@vger.kernel.org > Subject: Re: [patch v2 02/37] add opcodes to ib_pack.h > > On Sun, Jul 24, 2011 at 9:43 PM, <rpear...@systemfabricworks.com> wrote: > > > > Bring up to date with the current version of the IBTA spec. > > - add new opcodes for RC and RD > > - add new groups of opcodes for CN and XRC > > > > Signed-off-by: Bob Pearson <rpear...@systemfabricworks.com> > > > > --- > > include/rdma/ib_pack.h | 39 > ++++++++++++++++++++++++++++++++++++++- > > 1 file changed, 38 insertions(+), 1 deletion(-) > > > > Index: infiniband/include/rdma/ib_pack.h > > > ========================================================== > ========= > > --- infiniband.orig/include/rdma/ib_pack.h > > +++ infiniband/include/rdma/ib_pack.h > > @@ -75,6 +75,8 @@ enum { > > IB_OPCODE_UC = 0x20, > > IB_OPCODE_RD = 0x40, > > IB_OPCODE_UD = 0x60, > > + IB_OPCODE_CN = 0x80, > > + IB_OPCODE_XRC = 0xA0, > > A convention when submitting Linux kernel patches is to add only those > constants that are actually used in the code submitted in the same > patch series. So I'm not sure it's fine to add the XRC constants in > ib_pack.h through the rxe patch series. > > Bart. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
