OK. Since for now I don't need it I'll remove this patch but it might be
worth considering adding them as a standalone patch.

> -----Original Message-----
> From: bart.vanass...@gmail.com [mailto:bart.vanass...@gmail.com] On
> Behalf Of Bart Van Assche
> Sent: Monday, August 15, 2011 4:13 AM
> To: rpear...@systemfabricworks.com
> Cc: linux-rdma@vger.kernel.org
> Subject: Re: [patch v2 02/37] add opcodes to ib_pack.h
> 
> On Sun, Jul 24, 2011 at 9:43 PM, <rpear...@systemfabricworks.com> wrote:
> >
> > Bring up to date with the current version of the IBTA spec.
> >        - add new opcodes for RC and RD
> >        - add new groups of opcodes for CN and XRC
> >
> > Signed-off-by: Bob Pearson <rpear...@systemfabricworks.com>
> >
> > ---
> >  include/rdma/ib_pack.h |   39
> ++++++++++++++++++++++++++++++++++++++-
> >  1 file changed, 38 insertions(+), 1 deletion(-)
> >
> > Index: infiniband/include/rdma/ib_pack.h
> >
> ==========================================================
> =========
> > --- infiniband.orig/include/rdma/ib_pack.h
> > +++ infiniband/include/rdma/ib_pack.h
> > @@ -75,6 +75,8 @@ enum {
> >        IB_OPCODE_UC                                = 0x20,
> >        IB_OPCODE_RD                                = 0x40,
> >        IB_OPCODE_UD                                = 0x60,
> > +       IB_OPCODE_CN                                = 0x80,
> > +       IB_OPCODE_XRC                               = 0xA0,
> 
> A convention when submitting Linux kernel patches is to add only those
> constants that are actually used in the code submitted in the same
> patch series. So I'm not sure it's fine to add the XRC constants in
> ib_pack.h through the rxe patch series.
> 
> Bart.

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to