On 4/2/2012 12:47 PM, Or Gerlitz wrote:
> On 4/2/2012 7:35 PM, Hal Rosenstock wrote:
>> Rather than always overwriting active_speed in this case, wouldn't it
>> be better to only do that for invalid values?
> 
> Yes, I have thought about that, however, spotting invalid values would
> make the code a bit ugly, 

The code for this already exists inside of sysfs.c:rate_show anyhow and
just needs to be made into a global validation routine so mlx4/main.c
can access it. Only a slightly larger patch...

-- Hal

> so I took this approach, Roland?
> 
> Or.
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to