On Mon, Apr 02, 2012 at 06:39:36PM +0000, Hefty, Sean wrote: > > On 4/2/2012 7:35 PM, Hal Rosenstock wrote: > > > Rather than always overwriting active_speed in this case, wouldn't it > > > be better to only do that for invalid values? > > > > Yes, I have thought about that, however, spotting invalid values would > > make the code a bit ugly, so I took this approach, Roland? > > Does the active speed even make sense if the port is down? If not, > should we assume that any value returned by the FW is correct?
Force returning SDR makes sense to me. The link width probably has a similar problem too... Returning EINVAL from any sysfs query is really unfriendly. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
